Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests are wip] V4 to v5 upgrade will migrate app ID #2244

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[tests are wip] V4 to v5 upgrade will migrate app ID #2244

wants to merge 2 commits into from

Conversation

nan-li
Copy link
Contributor

@nan-li nan-li commented Jan 14, 2025 •
edited by niels-s
Loading

Description

One Line Summary

(Resolves an issue that only affects wrappers) When migrating from v4 to v5, check for a cached app ID from v4 if none are available on v5.

Details

Motivation

  • In wrappers, after an app upgrades from player to user model, if the app is not opened yet and a notification is received, there was no app ID detected and init returns early.
  • Now, check for the cached app ID from v4 and use that to continue the init process. This mimics what should happen when using the native SDK directly.
  • The reason this is an issue on wrappers is because when an app upgrades, the Application onCreate is called, without needing to open the app. However, in wrappers, the onCreate does not set app ID.

Scope

Using cached app ID from v4 if the app ID has not been set yet after migration.

Testing

Unit testing

Testing is WIP, still resolving how to call initWithContext within the tests.

Manual testing

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
  • I have reviewed this PR myself, ensuring it meets each checklist item

This change is Reviewable

nan-li added 2 commits January 14, 2025 11:25
@nan-li
Migrating from v4 to v5 checks for cached app ID
99c2020 
* In wrappers, after an app upgrades from player to user model, if the app is not opened yet and a notification is received, there was no app ID detected and init returns early.
* Now, check for the cached app ID from v4 and use that to continue the init process. This mimics what should happen when using the native SDK directly.
* The reason this is an issue on wrappers is because when an app upgrades, the Application `onCreate` is called, without needing to open the app. However, in wrappers, the `onCreate` does not set app ID.
@nan-li
test wip
44f7f9b
@nan-li nan-li added the WIP Work In Progress label Jan 14, 2025
@nan-li nan-li changed the title V4 to v5 upgrade will migrate app ID [tests are wip] V4 to v5 upgrade will migrate app ID Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
WIP Work In Progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nan-li